Repository navigation
Fix bug where error line numbers were incorrect in Rails 8.1 - #2502
Merged
Merged
Conversation
joelhawksley
force-pushed
the
20251119-ci
branch
from
November 19, 2025 21:30
cd86039 to
018ee8d
Compare
joelhawksley
changed the title
joelhawksley
marked this pull request as ready for review
November 19, 2025 21:50
Spone
reviewed
Nov 20, 2025
Spone
reviewed
Nov 20, 2025
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 8.1 added a newline to the compiled ERB output in rails/rails#53731, so we need to change our class_eval'd line number depending on the Rails version at compile time, but only for ERB.
I also made some appraisal updates here that get us closer to passing on Rails and Ruby main, but we are blocked by Nokogiri not supporting Ruby 4. I'm guessing that will change in the next couple of weeks ❤️